fix(#168): don't surface raw WS response body in send error#318
Open
LeJamon wants to merge 1 commit into
Open
Conversation
When the oneshot request receiver was dropped, sender.send returned the undeliverable message and it was embedded verbatim into MessageChannelError, leaking the raw response body into error channels. Drop the returned message and make MessageChannelError a data-free variant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #168.
When the oneshot request receiver had been dropped,
Sender::sendhanded back the undeliverable message and it was embedded verbatim intoMessageChannelError(String), surfacing the raw response body into error-reporting channels.The undeliverable message is now discarded and
MessageChannelErroris a data-free variant.Testing
cargo test --lib— addedhandle_message_routes_response_to_waiting_requestandunmatched_message_is_buffered_for_popcargo fmt --check; no_std feature set green