-
Notifications
You must be signed in to change notification settings - Fork 0
add index #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
msaleemzp
wants to merge
5
commits into
main
Choose a base branch
from
test-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add index #2
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| function executeUserScript() { | ||
| var userScript = document.getElementById('userScript').value; | ||
| eval(userScript); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| const express = require('express'); | ||
| const axios = require('axios'); | ||
| const { URL } = require('url'); | ||
| const dns = require('dns').promises; | ||
| const app = express(); | ||
|
|
||
|
|
||
| function isPrivateIp(ip) { | ||
| return ip === '::1' || | ||
| /^127\./.test(ip) || | ||
| /^10\./.test(ip) || | ||
| /^192\.168\./.test(ip) || | ||
| /^172\.(1[6-9]|2[0-9]|3[0-1])\./.test(ip) || | ||
| ip.startsWith('fc') || ip.startsWith('fd') || | ||
| ip.startsWith('fe80:'); | ||
| } | ||
|
|
||
| app.get('/', (req, res) => { | ||
| res.send('Hello World'); | ||
| }); | ||
|
|
||
|
|
||
| app.get('/fetch', async (req, res) => { | ||
| const url = req.query.url; | ||
| let parsedUrl; | ||
| try { | ||
| parsedUrl = new URL(url); | ||
| } catch (e) { | ||
| return res.status(400).send('Invalid URL'); | ||
| } | ||
| const hostname = parsedUrl.hostname; | ||
| if (!['http:', 'https:'].includes(parsedUrl.protocol) || | ||
| hostname === 'localhost' || | ||
| hostname === '127.0.0.1' || | ||
| hostname === '::1' || | ||
| /^(10|127)\./.test(hostname) || | ||
| /^172\.(1[6-9]|2[0-9]|3[0-1])\./.test(hostname) || | ||
| /^192\.168\./.test(hostname)) { | ||
| return res.status(400).send('URL not allowed'); | ||
| } | ||
| try { | ||
| // DNS resolution to prevent DNS rebinding | ||
| try { | ||
| const addresses = await dns.lookup(parsedUrl.hostname, { all: true }); | ||
| for (const { address } of addresses) { | ||
| if (isPrivateIp(address)) { | ||
| return res.status(400).send('URL not allowed'); | ||
| } | ||
| } | ||
| } catch (e) { | ||
| return res.status(400).send('Invalid hostname'); | ||
| } | ||
|
|
||
| const resp = await axios.get(url); | ||
| res.send(resp.data); | ||
| } catch (e) { | ||
| res.status(500).send(e.message); | ||
| } | ||
| }); | ||
|
|
||
| app.listen(3000, () => console.log('HTTP server on port 3000')); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| <?php | ||
|
|
||
| echo "<h>" +$_GET["search"] + "</h>"; | ||
|
|
||
| ?> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SSRF: /fetch endpoint does not validate redirect targets (Severity: MEDIUM)
Server-side request forgery (SSRF) can occur because the /fetch endpoint does not validate redirect targets, allowing attackers to access internal services. While the initial URL is checked, an attacker can host a server that redirects to internal resources, such as http://127.0.0.1:6379. This bypasses SSRF protections because axios on line 54 follows redirects by default, resulting in sensitive data from internal services being returned to the attacker via res.send(resp.data) on line 55.
View details in ZeroPath
💬 Reply
@zeropath-ai false-positive because …or@zeropath-ai accepted-risk because …to triage this finding, or ask it any question.All commands