fix(_release-rust): publish with PAT so release events cascade to downstream workflows#111
Merged
Merged
Conversation
The draft→upload→publish change (#110) made the publish transition (gh release edit --draft=false) run as GITHUB_TOKEN / github-actions[bot]. GitHub suppresses workflow triggers for events produced by GITHUB_TOKEN, so the resulting release: published event was sterile — downstream release-triggered workflows (crates publish, package publish) never ran. Publish with the caller's release PAT (secrets.pgp_signer_token) when provided, falling back to GITHUB_TOKEN. A PAT-authored publish cascades, restoring the pre-#110 behavior where the direct create-publish (also authored by the PAT) triggered downstream release workflows. Refs kunobi-ninja/kache#481
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After #110 switched the release job to draft→upload→publish, the publish transition (
gh release edit --draft=false) runs asGITHUB_TOKEN/github-actions[bot]. GitHub suppresses workflow triggers for events produced byGITHUB_TOKEN, so therelease: publishedevent is sterile — downstream release-triggered workflows never fire.Observed on kunobi-ninja/kache
v0.9.0-rc.1(first release after #110): the release published fine (immutable: true), butPublish cratesandPackage Publishnever ran. Comparison:emmanuelm41(PAT)github-actions[bot]Fix
Set the release step's
GH_TOKENto${{ secrets.pgp_signer_token || github.token }}— publish with the caller's release PAT when provided (already wired for signing), falling back toGITHUB_TOKEN. A PAT-authored publish cascades, restoring pre-#110 behavior. Consumers that don't passpgp_signer_tokenkeep the current (fallback) behavior.Notes
v10/v11moving tags advanced after merge (same as feat(_release-rust): draft→upload→publish for immutable releases #110).