Check artifact notes for unsupported claim language - #107
Merged
Conversation
Brings this core in line with ALEAPP #1242. Extends check_claim_language.py to the notes field, which reaches the report and the LAVA manifest and was not covered, and closes the habit stem in the claim vocabulary: the open spelling also matched "habitat". Notes get their own vocabulary. The completeness words come out, because a note legitimately states what it was tested against, and "read by" comes out because in a note it means read by the code rather than by a person. A match preceded by a negation inside the same clause is not reported; suppressed matches are counted and printed under --verbose rather than dropped silently. The new test pins the vocabulary to a literal and is byte-identical in all five cores, so a change made in one repo alone fails that repo's own CI. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings this core in line with ALEAPP #1242, which extended the claim-language check to the artifact
notesfield.notesis now checked. It reaches the report and the LAVA manifest and was not covered.read byis dropped because in a note it means read by the code.--verbose.Two notes reworded.