Scope each claim-language allowlist entry to its term - #108
Merged
Conversation
An ALLOWLIST entry was keyed on (file, artifact_key, field), so it silenced the whole field: allowlisting one word pre-approved every future claim anyone added to the same text. The key now carries the term, so an entry silences the word it was granted for and nothing else, and a report names only the terms no entry covers. Each existing entry keeps its effect. Its term was derived from what it silences today, so nothing new is reported: across the five cores 27 entries become 29 tuples, two of them having covered two terms each. Stale detection compares on the term as well, and the stale message names it. The shared test pins the new key shape, checks that every entry names a term the vocabulary can actually produce, and is byte-identical in all five cores. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the notes claim-checking work. An
ALLOWLISTentry was keyed on(file, artifact_key, field), so it silenced the whole field: allowlisting one word pre-approved every future claim added to the same text.Existing entries keep their effect: each term was derived from what it silences today, so nothing new is reported. Across the five cores 27 entries become 29 tuples, two of them having covered two terms each.