Anchor the passive claim forms on a person and complete the verb list - #109
Merged
Conversation
The passive family covered 4 of the 13 verbs the active family covers, so the check was evadable by voice alone: "the user created" was flagged and "created by the user" was not, with nothing about the claim changed. It was also unanchored, so "<verb> by" matched a subject that is not a person. Measured across the five cores, 24 of the 26 bare matches had one: "columns are read by position", "typed by the calling app". That is why `read by` had been dropped from the notes vocabulary and why two entries sat on the allowlist. Anchoring on a person fixes both directions. `read by` returns to the notes vocabulary, where it occurs zero times with a person as the subject, and the two entries it had forced are retired. The shared test pins the new vocabulary and asserts the two voices stay in step, so the asymmetry cannot reopen quietly. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The passive claim forms had two defects pointing opposite ways.
the user createdwas flagged andcreated by the userwas not, with nothing about the claim changed.<verb> bymatched a subject that is not a person. Across the five cores, 24 of the 26 bare matches had one:columns are read by position,typed by the calling app. That is whyread byhad been dropped from the notes vocabulary and why two entries sat on the allowlist.Anchoring on a person fixes both.
read byreturns to the notes vocabulary, where it occurs zero times with a person as the subject, and the two entries it forced are retired.The shared test pins the new vocabulary and asserts the active and passive voices stay in step.