Add a check for prose returned as a source path - #95
Merged
Conversation
The third element of an artifact's return tuple becomes the report's "located at" line and the LAVA manifest source_path, so it has to be real paths. A string constant there points the examiner at a column that often holds only a basename, and the location of the evidence ends up nowhere in the report. No artifact in this repo is affected; the check passes here as it stands. iLEAPP was swept for this class once already in its #2022 and #2024 and it had come back in two sibling cores, so it is added here to keep it from arriving later. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The third element of an artifact's return tuple becomes the report's "located at" line and the LAVA manifest source_path, so it has to be real paths. A string constant there points the examiner at a column that often holds only a basename, and the location of the evidence ends up nowhere in the report.
No artifact in this repo is affected; the check passes here as it stands. It is added because the class had already been swept out of iLEAPP once and had come back in two sibling cores.