Fix: Ford - PAS Dev Loc not Parsing - #132
Conversation
|
Thanks for the contribution! This PR changes artifact modules without test data for them. A small fixture with each artifact change lets reviewers run the module against real data, and the committed case keeps guarding the module after merge.
Adding a fixture Generate it from your extraction with the helper (details in create_module_test_cases.md): It writes Size rules:
If your extraction cannot be shared:
If none of those fit, say so here and we will work it out. The PR can still be reviewed and merged with the gap recorded in the artifact's This is a request, not a gate. Nothing here blocks review. |
|
Thanks, I will work on that. I have been unable to find any public images for Ford Sync and the data I have does contain personal info. I am in the process of sanitizing it and will add it when I'm able. |
|
Thanks for this, and welcome. Strong first pull request. Both problems you found are real and I reproduced them here. The seekers hand an artifact the directory path as well as the file inside it, and opening that directory stops the loop, so every log after it goes unparsed. The gzip handling and the Two things to fix before it goes in:
Three smaller ones:
One to watch: Only the test data bot has run so far. The rest of CI needs my approval on a first pull request and I will kick it off. No rush on the fixture, and sanitizing in place is the right call. |
Extraction from Sync3 did not parse locations due to format with semicolon separator.
Example data: 8/07/2026 5:56:51.842/23156/23/NAV_FRAMEWORK_IF/dev_loc_results/682/=pos_result.Tcount:11565508 GPS Input Lon:-42.123472 Lat:32.123444 Alt:199.000000 Hd:160.383911
Also received access denied error and found that script was attempting to open a directory "pas_debug.log.11" instead of the file with the same name that was within.
The script appeared to stop processing after the above error and didn't attempt to parse additional logs.
All but 2 or 3 of the 25+ logs were stored in gzip archives which were not parsed.
Script vibe coded with Claude.
Updated script went from 0 locations to over 52,000. I also successfully tested the script with a Sync4 extraction. The Sync4 extraction used the same syntax with the semicolon, but did not have any gzip and no directories with same name as the file..
1st time submitting a pull request so let me know if I missed anything.