Give the test harness the data folder, so path columns are comparable - #2050
Merged
Conversation
Context.get_relative_path returns its argument unchanged when _data_folder is unset. The harness set the report folder, the seeker and files_found but never the data folder, so inside it that function did nothing: an artifact leaking an absolute path and one reporting an extraction-relative path recorded identical output, and no fixture could tell them apart. 42 recorded units carried the recorder's own temp directory in a data cell as a result. The case zip is extracted into temp_dir, so temp_dir is the harness equivalent of the seeker's data folder. Adds Context.set_data_folder for the harness to say so, since it has no OutputParameters to pass. Baselines re-recorded for the 42 affected units. Every changed cell differs only by the temp directory prefix; no headers, row counts or values moved. KeepSafe read plist dates with a bare datetime.timestamp(). A plist date is UTC but plistlib returns a naive datetime, so that read it as local time and the reported timestamps shifted by the offset of whoever ran the tool: 21,600 seconds on a UTC-6 host. Pinned to UTC, which is also what the existing baselines hold, so the recorded values did not change. The suite now gives the same result in any timezone. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context.get_relative_path returns its argument unchanged when _data_folder is unset. The harness set the report folder, the seeker and files_found but never the data folder, so inside it that function did nothing: an artifact leaking an absolute path and one reporting an extraction-relative path recorded identical output, and no fixture could tell them apart. 42 recorded units carried the recorder's own temp directory in a data cell.
Adds Context.set_data_folder, since the harness has no OutputParameters to pass. Baselines re-recorded for the 42 affected units; every changed cell differs only by that prefix, and no headers, row counts or values moved.
KeepSafe read plist dates with a bare datetime.timestamp(). A plist date is UTC but plistlib returns a naive datetime, so it was read as local time and shifted by the offset of whoever ran the tool. Pinned to UTC, which is what the baselines already held, so no recorded value changed and the suite now gives the same result in any timezone.