Build data_headers before the loop, not inside it - #2055
Merged
Conversation
These artifacts filter wal, shm and journal files out of files_found before looping, so the list they iterate can be empty even though the framework only calls an artifact when its glob matched. data_headers was assigned inside that loop and read by the return, so an extraction where the glob matched only a sidecar raised UnboundLocalError instead of reporting no rows. The tuple is a constant with no reference to the loop variable, so hoisting it changes nothing when the loop runs. Verified by comparing the parsed literal before and after: identical in all three functions. Only these three of the twenty functions that assign inside a loop are reachable. The rest iterate files_found directly, which the entry point guarantees is non-empty, and are left alone. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These artifacts filter wal, shm and journal files out of files_found before looping, so the list they iterate can be empty even though the entry point only calls an artifact when its glob matched. data_headers was assigned inside that loop and read by the return, so an extraction where the glob matched only a sidecar raised UnboundLocalError instead of reporting no rows.
The tuple is a constant with no reference to the loop variable, so hoisting it changes nothing when the loop runs. Verified by comparing the parsed literal before and after: identical in all three functions.
Only these three of the twenty functions that assign inside a loop are reachable. The rest iterate files_found directly, which the entry point guarantees is non-empty, and are left alone.