Read older-layout Reminders columns from the store's cached model - #2291
Merged
Merged
Conversation
In the older store layout (the iOS 13.3.1, 14.3, 15.0.2 and 15.3.1 test images) a reminder is a REMCDReminder row of ZREMCDOBJECT, beside accounts, lists, alarms and other entities, and a property name several of those entities define is kept in numbered columns. The artifact hardcoded ZCREATIONDATE, but in the iOS 15 models REMCDHashtag (entity 24) also defines creationDate, so a reminder's creation date is in ZCREATIONDATE1 and Creation Date came out blank. The older-layout branch now works out the table and the column of each property from the Core Data model the store caches in Z_MODELCACHE, with the helpers from DLEAPP's macosReminders.py (DLEAPP #340). A store whose model cannot be read is logged and not read, and a property whose column cannot be decided is logged and reported blank. The ZREMCDREMINDER branch for iOS 16 and later is unchanged. A new unit test builds older-layout stores with the iOS 14.3 and 15.0.2 entity numbers and fails on the previous code. Row counts are unchanged on the 22 registered iOS images that carry Reminders stores, nine of them newly recorded in sample_data. None of them holds older-layout reminders, and the notes say so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Reminders on the older store layout (the iOS 13.3.1 to 15.3.1 test images), where reminders are ZREMCDOBJECT rows and some columns are numbered. On iOS 15 a reminder's creation date is in ZCREATIONDATE1, not ZCREATIONDATE, so Creation Date came out blank.
No registered image holds older-layout reminders, and the notes say so.
🤖 Generated with Claude Code