Skip to content

NOISSUE - Use attestation-agent config and add Wasmtime cache#219

Open
rodneyosodo wants to merge 1 commit into
absmach:mainfrom
rodneyosodo:fix/update-tee
Open

NOISSUE - Use attestation-agent config and add Wasmtime cache#219
rodneyosodo wants to merge 1 commit into
absmach:mainfrom
rodneyosodo:fix/update-tee

Conversation

@rodneyosodo

Copy link
Copy Markdown
Contributor

What type of PR is this?

What does this do?

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Did you document any new/modified features?

Notes

Comment thread hal/ubuntu/qemu.sh
[token_configs]
[token_configs.coco_kbs]

[token_configs.kbs]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kbs renamed from coco_kbs; AA version must support this key.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It does

Comment thread hal/ubuntu/qemu.sh
Type=simple
EnvironmentFile=/etc/default/proplet
Environment=WASMTIME_HOME=/var/lib/proplet
Environment=WASMTIME_CACHE_DIR=/var/cache/wasmtime

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WASMTIME_CACHE_DIR is not recognized by Wasmtime; use WASMTIME_CACHE_CONFIG.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasmtime has neither env variables. It is just unix style https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch05s05.html

Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>

@JeffMboya JeffMboya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread hal/ubuntu/qemu.sh
ProtectSystem=strict
ProtectHome=true
ReadWritePaths=/var/lib/proplet /tmp
ReadWritePaths=/var/lib/proplet /var/cache/wasmtime /tmp

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we hard-coding for only one Wasm runtime? Who is guaranteeing that only Wasmtime will be used? Are we hard-coding this on purpose?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are shipping the qemu config with the default wasmtime installed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants