Repository navigation
Conversation
|
Once we settle on a style the same change can be applied to other repos. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
==========================================
- Coverage 50.10% 49.87% -0.23%
==========================================
Files 62 62
Lines 3838 4002 +164
==========================================
+ Hits 1923 1996 +73
- Misses 1915 2006 +91 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Sir, you are right: #74 was a mess after blue style formatting. I show you an example: # before JuliaFormatter
for instance in 1:(X |> size |> first)
] |> x -> filter(!isnothing, x)
# after JuliaFormatter
for instance in 1:(first(size(X)))my concern is: is it normal? |
|
I see, perhaps there are some configs to control these behavior. I'll change to blue style and see if we can avoid these |> rewritings. In this specific case though the semantics is the same and I prefer the syntax without |>, so I see no issue. Are there other cases where it can potentially affect the code? |
|
This is the one that take my attention. I don’t remember other changes, but if I find other “code refactoring” I will post here. |
|
Hi guys! Don't worry for the pipe, actually I rarely see it in others' code and is fine to keep a more traditional style. @giopaglia I would prefer four spaces for indenting. Together with the ruler set at 80 characters (I think this is the default in the blue style), it is a good "guardrail" for avoiding very long messy lines even when I am distracted. Does this make sense? |
|
Makes sense so iiuc we want blue style. I’ll update this mr and request
review
*GP*
Il giorno dom 8 mar 2026 alle 21:56 Mauro Milella ***@***.***>
ha scritto:
… *mauro-milella* left a comment (aclai-lab/SoleData.jl#76)
<#76 (comment)>
Hi guys! Don't worry for the pipe, actually I rarely see it in others'
code and is fine to keep a more traditional style.
@giopaglia <https://github.com/giopaglia> I would prefer four spaces for
indenting. Together with the ruler set at 80 characters (I think this is
the default in the blue style), it is a good "guardrail" for avoiding very
long messy lines even when I am distracted.
Does this make sense?
—
Reply to this email directly, view it on GitHub
<#76 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF3CJLO63SQNUQZCZ6HAKJL4PXM6HAVCNFSM6AAAAACWKUAB6SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DAMJZHE4TOMBZGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hi guys, sorry if I'm late to the party! Yes, let's go with blue style 😎 (@mauro-milella you make me proud asking for the 80 characters per line) I just wanted to add a comment on the github action: together with @ferdiu we decided to have an action for checking that the blue style guidelines are followed (i.e., differently from the proposed action, which automatically applies blue syle calling the formatter). We are working on it (: |
Why not let ci autofix the syntax? Your suggestion seems to need more manual work from developers |
This branch has not been deployed
4 participants
#74 is introducing some changes + blue style formatting, which makes inspecting the diff hard.
So let's deal with autoformatting first: let's add an JuliaFormatter.toml + a Julia action.
But which style should we go for? Has this been discussed already? Some Sole packages have JuliaAutoformatter.toml, like https://github.com/aclai-lab/SoleLogics.jl/blob/main/.JuliaFormatter.toml and https://github.com/aclai-lab/Sole.jl/blob/main/.JuliaFormatter.toml, but it's a sciml-based one (not blue style).
One thing I can advocate for is using two spaces instead of four for indenting. I often find that 4 are unnecessary. Other than that, I'm fine with either blue style or sci ml.