SK-271 // replace stable-spec with owner mtime for pod tracking - #265
Open
drmorr0 wants to merge 1 commit into
Open
SK-271 // replace stable-spec with owner mtime for pod tracking#265drmorr0 wants to merge 1 commit into
drmorr0 wants to merge 1 commit into
Conversation
drmorr0
force-pushed
the
drmorr/stable-pod-spec-hash
branch
2 times, most recently
from
August 14, 2026 21:11
1af42fe to
8199d4c
Compare
1 task
drmorr0
force-pushed
the
drmorr/stable-pod-spec-hash
branch
2 times, most recently
from
August 19, 2026 05:09
8fedb7b to
8f50948
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #265 +/- ##
==========================================
+ Coverage 79.35% 79.39% +0.04%
==========================================
Files 61 62 +1
Lines 4000 3999 -1
==========================================
+ Hits 3174 3175 +1
+ Misses 826 824 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
drmorr0
force-pushed
the
drmorr/stable-pod-spec-hash
branch
3 times, most recently
from
August 19, 2026 17:59
1e93c0c to
4321a1b
Compare
drmorr0
commented
Aug 19, 2026
| pub fn store_object(&mut self, owner_id: KubeResourceId, hash: u64, mtime: i64) { | ||
| let entry = self.m.entry(owner_id).or_default(); | ||
| entry.hash = Some(hash); | ||
| entry.mtimes.push(mtime); |
Contributor
Author
There was a problem hiding this comment.
add a check here that the mtimes are monotonic
drmorr0
force-pushed
the
drmorr/stable-pod-spec-hash
branch
3 times, most recently
from
August 25, 2026 23:05
98504d4 to
45a1ce0
Compare
drmorr0
changed the title
drmorr0
force-pushed
the
drmorr/stable-pod-spec-hash
branch
from
August 26, 2026 05:11
45a1ce0 to
29d63cd
Compare
drmorr0
force-pushed
the
drmorr/stable-pod-spec-hash
branch
from
August 26, 2026 20:22
29d63cd to
56da27b
Compare
drmorr0
force-pushed
the
drmorr/stable-pod-spec-hash
branch
from
August 27, 2026 05:06
56da27b to
89eca7c
Compare
drmorr0
force-pushed
the
drmorr/stable-pod-spec-hash
branch
from
August 27, 2026 05:12
89eca7c to
9f790f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and Rationale
How
Test Steps
Other Notes
TODO
I certify that this PR does not contain any code that has been generated with GitHub Copilot or any other AI-based code generation tool, in accordance with this project's policies.