Skip to content

USF-4024: breadcrumb on PLP page #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
keoko wants to merge 2 commits into
base: plp
Choose a base branch
from
Open

USF-4024: breadcrumb on PLP page #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66255f0
fix(plp-renderer): move breadcrumb outside product-list-page and use …
keoko May 4, 2026
7daad79
fix(e2e): update breadcrumb selector from nav to div in plp-ssg test
keoko May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions actions/plp-renderer/templates/product-listing.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
<h1>{{categoryName}}</h1>
<div class="breadcrumb">
<div>
<div>

@svera svera May 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't nav more semantic for breadcrumbs?

https://developer.mozilla.org/en-US/docs/Web/CSS/How_to/Layout_cookbook/Breadcrumb_navigation

There is also an aria label specific for them

<ol>
{{#each breadcrumbs}}
<li><a href="{{url}}">{{name}}</a></li>
{{/each}}
</ol>
</div>
</div>
</div>
<div class="product-list-page">
<div>
<div>urlPath</div>
<div>{{categorySlug}}</div>
</div>
<div>
<div>
<nav class="breadcrumb" aria-label="Breadcrumb">
<ol>
{{#each breadcrumbs}}
<li><a href="{{url}}">{{name}}</a></li>
{{/each}}
</ol>
</nav>
</div>
</div>
{{#if categoryDescription}}
<div>
<div><h2>Description</h2></div>
Expand Down
4 changes: 2 additions & 2 deletions e2e/plp-ssg.e2e.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,8 @@ describe(`PLP e2e - slug: ${slug}`, () => {
}
});

test('breadcrumb nav exists with at least one link', () => {
const breadcrumbLinks = $('nav.breadcrumb a');
test('breadcrumb div exists with at least one link', () => {
const breadcrumbLinks = $('div.breadcrumb a');
expect(breadcrumbLinks.length).toBeGreaterThan(0);
breadcrumbLinks.each((_, el) => {
const href = $(el).attr('href');
Expand Down
Loading