CEXT-6421: add isWebhookSuccessful helper to lib-webhooks#563
Merged
Conversation
🦋 Changeset detectedLatest commit: 2298640 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
iivvaannxx
reviewed
Jul 10, 2026
The function now resides in the responses module of the library.
github-actions
Bot
added
the
pkg: aio-commerce-lib-core
iivvaannxx
approved these changes
Jul 10, 2026
Co-authored-by: Ivan Porto Wigner <dev.ivanporto@gmail.com>
jcuerdo
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
isWebhookSuccessful()to@adobe/aio-commerce-lib-webhooks/responsesto determine whether a webhook action's result is successful.Related Issue
CEXT-6421
Motivation and Context
Adobe Commerce webhooks always respond with HTTP 200, even when the handler wants to signal an error — the actual outcome is only visible in the response body's
opfield (op: "exception"= failure). Tooling that instruments webhook actions generically, such as tracing libraries (e.g.aio-lib-telemetry), can't rely on the status code alone to classify the result. This helper closes that gap.How Has This Been Tested?
Added unit tests covering: non-200 status codes, missing/no-op bodies, exception operations, success/add/replace/remove operations, arrays of operations, and non-object inputs. Ran
pnpm --filter @adobe/aio-commerce-lib-webhooks test(100% coverage),typecheck, andlint.Types of changes
Checklist: