[codex] Unify GPU renderer FMA detection#71
Closed
adpena wants to merge 1 commit into
Closed
Conversation
Move the duplicated Add(Mul(..), ..) detector into render::detect_fma_pattern and route CUDA, HIP, MSL, OpenCL, and WGSL through that single authority. Proof: 20260706T154656-molt-gpu-clippy-all-targets-stable-20260706-d887354bd1af46e9 passed cargo clippy -p molt-gpu --all-targets --all-features -- -D warnings. Also passed git diff --check and tools/check_rustfmt.py --changed. Note: 20260706T154817-molt-gpu-tests-after-fma-detector-20260706-0bd7339d2de54954 did not reach assertions; it failed during rustc metadata emission with Windows os error 1450 under the 2026-07-06 witness-exclusive heavy-build hold.
Owner
Author
|
Superseded by clean signal-only PR #72, which cherry-picked only the six renderer FMA detection files onto current origin/main and has merged. Closing this stale draft branch to avoid carrying old merge-history baggage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
render::detect_fma_patternValidation
20260706T154656-molt-gpu-clippy-all-targets-stable-20260706-d887354bd1af46e9:cargo clippy -p molt-gpu --all-targets --all-features -- -D warningspassedgit diff --check -- runtime/molt-gpu/src/render/...passed.venv\Scripts\python.exe tools\check_rustfmt.py --changedpassed for the six changed Rust filesNotes
20260706T154817-molt-gpu-tests-after-fma-detector-20260706-0bd7339d2de54954did not reach test assertions. It failed during rustc metadata emission with Windowsos error 1450while the 2026-07-06 board has an emergency witness-exclusive heavy-build hold active, so I did not launch another heavy cargo proof.