[codex] Fix mainline CI backend lints#73
Merged
Conversation
Indent the continuation lines under the split-field inlining doc bullet so clippy::doc_lazy_continuation does not fail the LLVM Backend gate. Proof: CI job 85417462124 failed on runtime/molt-passes/src/tir/passes/inliner/eligibility.rs:186-187 with clippy::doc_lazy_continuation. Local checks passed: git diff --check and tools/check_rustfmt.py --changed for the touched file. Local cargo/clippy was intentionally not rerun under the 2026-07-06 witness-exclusive heavy-build hold.
The previous import was gated only on wasm-backend, but the Luau and Rust backend output paths also call File::write_all. Gate std::io::Write on all backend-output writer features. Proof: wasm-build job 85421652455 failed on cargo build -p molt-backend --no-default-features --features luau-backend with E0599 at runtime/molt-backend/src/backend_output.rs:177. Local checks passed: git diff --check and tools/check_rustfmt.py --changed for the touched file.
adpena
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clippy::doc_lazy_continuationfailure in the inliner split-field eligibility docsFile::write_alltrait import for Luau/Rust/WASM writer feature setsRoot causes
runtime/molt-passes/src/tir/passes/inliner/eligibility.rshad a Markdown list item followed by unindented continuation lines. With Rust 1.96 Clippy and-D warnings, the LLVM Backend gate failed before reaching its intended backend assertions.runtime/molt-backend/src/backend_output.rsimportedstd::io::Writeonly underwasm-backend, but the Luau and Rust backend output paths also callFile::write_all. The CI Luau build therefore failed with E0599.Validation
85417462124,LLVM Backend,runtime/molt-passes/src/tir/passes/inliner/eligibility.rs:186-18785421652455,wasm-build,runtime/molt-backend/src/backend_output.rs:177git diff --checkpassed for the touched files.venv\Scripts\python.exe tools\check_rustfmt.py --changedpassed for the touched filesNotes
Local cargo/clippy was kept scoped because CI is exercising the exact failing gates. No witness inputs, frozen module ABI, or dynamic-call lanes are touched.