Skip to content

Added an automated way to update styles.js - #13

Open
ErikRospo wants to merge 15 commits into
adri326:mainfrom
ErikRospo:main
Open

Added an automated way to update styles.js#13
ErikRospo wants to merge 15 commits into
adri326:mainfrom
ErikRospo:main

Conversation

@ErikRospo

Copy link
Copy Markdown

Made a way to update styles.js automatically. However, I was not sure how to generate the steps part, so I hard coded that

@ErikRospo

ErikRospo commented Aug 6, 2022

Copy link
Copy Markdown
Author

In addition, I have a clone that includes a way to do input images, albeit in a spaghetti way, so I am not sure if I should put that in here, or on another PR

@adri326

adri326 commented Aug 10, 2022

Copy link
Copy Markdown
Owner

Maybe on another PR; it looks like your PR lost all information on file permissions and added +x to every digit, which is a bummer

@ErikRospo

Copy link
Copy Markdown
Author

Ok, didn't realize

@ErikRospo

ErikRospo commented Aug 10, 2022

Copy link
Copy Markdown
Author

Fixed.

@adri326

adri326 commented Oct 12, 2022

Copy link
Copy Markdown
Owner

Hmm, I'll have to take a deeper look at this because the github diff doesn't like your changes for some reason

@ErikRospo

Copy link
Copy Markdown
Author

What do you mean by not liking my changes?

@adri326

adri326 commented Oct 14, 2022

Copy link
Copy Markdown
Owner

idk, github is showing me files that had no change as fully rewritten in the diff view

@ErikRospo

ErikRospo commented Oct 14, 2022

Copy link
Copy Markdown
Author

I believe those are white-space only changes. E.G. \r\n to \n, or \n to \r\n
Github has an option to ignore those, i believe it is under the filters of the diff.
Alternatively, This has it enabled by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants