Repository navigation
fix(google): preserve text thought signatures across continuations - #1127
Merged
mikehostetler merged 4 commits intoOct 26, 2026
Merged
mikehostetler merged 4 commits into
mikehostetler merged 4 commits into
Conversation
Contributor
Author
|
The fix passes the default test suite and quality checks. I’ve left this as a draft because the Google compatibility matrix fails. The one fixture mismatch is confirmed on the upstream baseline. Would you prefer the fixture issues handled separately, or resolved before marking this PR ready for review? |
12 of 14 tasks
gabrielrinaldi
force-pushed
the
fix/google-text-thought-signatures
branch
from
October 24, 2026 22:32
96d9aee to
7191628
Compare
mikehostetler
marked this pull request as ready for review
October 26, 2026 13:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preserve Gemini thoughtSignature values on ordinary text parts, including empty signature-only parts, through buffered decoding, stream assembly, and continuation encoding.
Compatibility drift
This PR also resolves #1153.
Current status
Rebased onto main through 9377b99. The current head is 514fac9.
All required GitHub checks pass, including the Elixir and OTP test matrix, formatting, Credo, Dialyzer, audit, docs, and package validation.
Testing
mix mc 'google:*' --max-concurrency 4: 10 covered models pass, 29 models are untested, and 5 models are retiredmix quality: passedChecklist
Related work
Closes #1153