Repository navigation
Preserve message names in loose maps - #1146
Merged
mikehostetler merged 1 commit intoOct 24, 2026
Merged
mikehostetler merged 1 commit into
mikehostetler merged 1 commit into
Conversation
mikemikimike
force-pushed
the
codex/fix-preserve-message-name-1145
branch
from
October 23, 2026 22:30
35bd402 to
84fb099
Compare
mikehostetler
approved these changes
Oct 24, 2026
mikehostetler
left a comment
mikehostetler
left a comment
Contributor
There was a problem hiding this comment.
I found no blocking issues. The change preserves participant names for the supported loose-map forms. GitHub CI is green, and the focused suite passed 175 tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve the optional participant name when generic message maps are normalized, including atom/string roles and keys, text and content-part messages, and assistant tool-call messages. Non-string names remain unset. The regression tests verify normalization and OpenAI-compatible encoding.
Fixes #1145
Issue: #1145
Tests:
mix test test/req_llm/context_test.exs test/req_llm/provider/defaults_test.exs(175 passed)mix format --check-formattedmix compile --warnings-as-errorsmix credo --strict(0 issues)mix dialyzer(0 errors)mix test(5,366/5,408 passed; the remaining 42 failures are in compatibility evidence, billing, release packaging, OAuth/GitHub CLI mocks, and network/stream timing; the failure set matches the clean-base baseline apart from a non-deterministic telemetry failure)