Repository navigation
fix(timeout): preserve OpenTelemetry context in deadline tasks - #1149
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A finite
total_timeoutruns the request in a task that loses the caller’s process-local OpenTelemetry context. Capture that context before spawning the task and attach it before running the request, preserving parent trace selection and baggage. OpenTelemetry remains optional at runtime.Regression tests use the real context API through a test-only dependency and cover finite/unlimited budgets, an empty context, and isolation of task changes across successive requests.
Type of Change
Breaking Changes
None.
Testing
mix test: 5,416 passed, 11 skipped, 240 excluded by default.mix quality: formatting, warnings-as-errors compilation, Credo, Dialyzer passed.Checklist
CHANGELOG.mdunchanged.Related Issues
Closes #1148.
Need help on this PR? Tag
@codesmith-botwith what you need.