fix(component): roll back failed startup - #426
Open
RerankerGuo wants to merge 1 commit into
Open
Conversation
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Roll back partially started component lifecycles when
BaseComponent.start()fails.Problem
start()currently starts owned dependencies before invoking the parent's_start(). If the parent hook raises, the parent remains marked as not started, so a laterclose()returns immediately while the owned components remain running.This can leak clients, tasks, or other resources created by default-factory dependencies.
Changes
Evidence
Before the fix:
After the fix:
All relevant pre-commit hooks pass.
Scope
Successful startup and normal idempotent close behavior are unchanged.