Fixing a bug in reverse lookup of ID to enum

[rvs]

When I was trying to replace SP_BL2 in the image I've noticed that SP_BL2 resolves to numeric ID 0x9 in the enum at firmware-flash-tool/include/esperanto_flash_image.h:18. The replace path then matches regions by numeric region_id, not by the printed string, at firmware-flash-tool/src/esperanto_flash_image_replace.c:90.

The bad output comes from region_id_to_name(), which assumes the lookup table is in enum order, but the table has PMIC_FW_S0 and PMIC_FW_S1 inserted before SP_BL1/SP_BL2 at firmware-flash-tool/src/parse_template_file.c:31. So ID 0x9 gets mislabeled as PMIC_FW_S1 when printed at firmware-flash-tool/src/parse_template_file.c:71.

Arguably this can be maintained at the cost of precise ordering, but it seems that a quick scan of the table is a better option

[vidas]

LGTM

[AFOliveira]

Code-wise looks good to me, but I still didn't get to get hands-on with FW on the ET, neither do I have a board to test the change on, so I'll refrain from the approval and let Vidas and Gianluca properly approve it.

[glguida]

Yes, this is something that I noticed back when I was playing with it.

Thanks for the patch!