[16.0][REF] Move report conflicting with standard module#244
Open
mihien wants to merge 1 commit into
Open
Conversation
mihien
force-pushed
the
16.0-ref-pos_usability
branch
3 times, most recently
from
a7d03c8 to
6fb57fb
Compare
huguesdk
suggested changes
May 6, 2026
huguesdk
left a comment
huguesdk
left a comment
There was a problem hiding this comment.
i had trouble understanding what the conflict is about (especially since there doesn’t seem to be any problem if pos_daily_sales_report is installed after pos_usability). an explanation of the “why” in the commit message would be useful (explaining that pos_daily_sales_report removes the part of the report that this report is modifying).
pos_daily_sales_reports removes the part of report_saledetails that this module is modifying
mihien
force-pushed
the
16.0-ref-pos_usability
branch
from
6fb57fb to
d941636
Compare
ak-git-bot
added
mod:pos_usability
huguesdk
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move pos sale report conflicting with standard module pos_daily_sales_reports out of pos_usability and to a new module named pos_sale_report_tax_amount.