Fixed referencial styles not being inherited by region, especially fo…#33
Open
alexandercerutti wants to merge 2 commits into
Open
Fixed referencial styles not being inherited by region, especially fo…#33alexandercerutti wants to merge 2 commits into
alexandercerutti wants to merge 2 commits into
Conversation
…r what concern styles that apply directly to the region itself and not children
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR targets TTML region style association (#32) by ensuring regions correctly apply styles referenced via their own style attribute, including region-box-only properties like tts:origin and tts:extent.
Changes:
- Validates and threads region
styleIDREFs into the region’s temporal-active style resolution. - Switches region style computation to use
TemporalActiveContext.computeStylesForElement("region")and filters geometry vs visual styles by computed CSS property keys. - Adds a spec asserting that region geometry (origin/extent) is inherited from a global referenced style.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/ttml-adapter/src/Parser/Scope/RegionContainerContext.ts | Includes region style IDREFs in temporal style resolution; refactors region visual/geometry style computation. |
| packages/ttml-adapter/specs/Adapter.spec.mjs | Adds regression test for region geometry inheritance via referenced global styles. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+448
to
452
| function computeRegionStylesByScope(scope: Scope): Record<string, string> { | ||
| const temporalActiveContext = isolateContext(readScopeTemporalActiveContext(scope)); | ||
|
|
||
| if (!styleContext) { | ||
| if (!temporalActiveContext) { | ||
| return {}; |
Comment on lines
+208
to
+210
| const idrefsStyleList = idrefs!.split(/\s+/); | ||
| const referencialStyles: string[] = []; | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32