[WEBVTT] Added support to X-TIMESTAMP-MAP HLS header#35
Open
alexandercerutti wants to merge 8 commits into
Open
[WEBVTT] Added support to X-TIMESTAMP-MAP HLS header#35alexandercerutti wants to merge 8 commits into
alexandercerutti wants to merge 8 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Adds initial support for HLS X-TIMESTAMP-MAP in webvtt-adapter by parsing the header and rebasing cue timestamps, plus expands test coverage for BOM + timestamp-map behavior.
Changes:
- Parses
X-TIMESTAMP-MAPfrom the WEBVTT header and applies anoffsetMsto cue start/end times. - Extends
InvalidFormatErrorreason codes to include invalidX-TIMESTAMP-MAP. - Adds Jest specs covering BOM handling and multiple
X-TIMESTAMP-MAPscenarios.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
| packages/webvtt-adapter/src/InvalidFormatError.ts | Adds a new reason code for invalid X-TIMESTAMP-MAP. |
| packages/webvtt-adapter/src/Adapter.ts | Implements header parsing for X-TIMESTAMP-MAP and applies a cue time offset. |
| packages/webvtt-adapter/specs/Adapter.spec.mjs | Adds tests for BOM and X-TIMESTAMP-MAP rebasing cases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #34