feat: set users ID to be autoincrementing - #240
Conversation
|
I noticed there are some test failures. Does your change pass the tests locally? |
Should be fixed, but I have not deployed this to test yet. |
|
OK Looks great. How did you notice this? I was wondering if we could have a test that reproduced the original issue in a similar way that you noticed it through the API e.g.:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #240 +/- ##
==========================================
- Coverage 90.96% 90.89% -0.08%
==========================================
Files 113 114 +1
Lines 11749 11779 +30
==========================================
+ Hits 10687 10706 +19
- Misses 1062 1073 +11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
It might be quite long to add a test like that. I found this issue through an AI passthrough (and a few others, but those fixes are larger). |
Please sync and rebase. I added the test in #241 setup for you to update with your fix. |
allenporter
left a comment
There was a problem hiding this comment.
Marking request changes; update the test that should reproduce the issue.
603b45c to
0b52cd0
Compare
User IDs are currently recycled as the column is an ROWID. When a user is deleted from the database, a new user can obtain the same User ID, and the old user's files are assigned to the new user who now has full access to them. This changes the column to be autoincremented and also ensures this for old deployments.