Repository navigation
Fix Parse.ly Content API compatibility - #485
adamehirsch wants to merge 3 commits into
Conversation
mogmarsh
left a comment
There was a problem hiding this comment.
@adamehirsch Thanks for the submission!
This looks good, and I'm approving it...
However, if you feel up for it, I wouldn't mind a few changes. We are fine with only supporting wp-parsely 3.20.4 and later (because that version is already over a year old), so the PR could be updated to return early if the plugin doesn't exist or it's older than 3.20.3. This should simplify things a lot. If you're not up for it, let me know and I'll merge this in, or bring it into our repo and make the changes myself.
Let me know if you have any questions.
Thanks!
|
@mogmarsh -- I'm totally fine to make the change -- won't that mean that upgrading will require us to bump both this and |
|
@adamehirsch we can upgrade them both in one PR and test the effects. |
|
Updated to require wp-parsely 3.20.4+. This removes the legacy client fallback and pre-3.20.4 section conversion while retaining Content API tag normalization. We'll expect to test and update |
|
Dependabot check seems to have skipped for some reason, but this is ready to check/deploy from my side, @mogmarsh |
Sat down with my little robot friends to try and fix #281 .
Analytics_Posts_APIclass.$parselyinstance instead of rereading$GLOBALS.Testing