feat: add tx_index, block env, and tx env access to TracingCtx - #296
Open
stevencartavia wants to merge 3 commits into
Open
feat: add tx_index, block env, and tx env access to TracingCtx#296stevencartavia wants to merge 3 commits into
stevencartavia wants to merge 3 commits into
Conversation
mattsse
reviewed
Feb 24, 2026
Comment on lines
+163
to
+166
| let tx_env = tx.clone().into_tx_env(); | ||
| let tx_index = self.tx_index; | ||
| self.tx_index += 1; | ||
| let result = self.inner.evm.transact_raw(tx_env.clone()); |
Member
There was a problem hiding this comment.
this is too expensive, this does more clones now
ideally we find a better solution for this
Contributor
Author
There was a problem hiding this comment.
removed the tx_env field, added it as a method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
TracingCtxcurrently exposestx,result,state,inspector, anddb. Callers that need the transaction's position in the block or access to the EVM environment must track these externally (e.g. manualidxcounters, capturingblock_number/base_feefrom outer scope).Solution
Add three fields to
TracingCtx:tx_index: usize— tracked via a counter inTracerIter, starts at 0 and increments each iterationblock_env: &E::BlockEnv— cloned once atTracerIterconstruction and passed by reference to each callbacktx_env: E::Tx— the resolved transaction environment used for executionNo breaking changes to the
Evmtrait. No unsafe code.PR Checklist