fix(android): make OpenSL capture shutdown deterministic - #52
Open
Avejack wants to merge 2 commits into
Open
Conversation
Stop the OpenSL recorder before clearing queued capture buffers instead of waiting indefinitely for a stalled Android USB input queue to drain. Preserve playback draining, add regression coverage, and document the pending change.
Declare the build and platform exclusions added automatically by Flutter 3.47 so dependency resolution leaves the checkout clean before the pub.dev dry-run gate.
Owner
|
Hi @Avejack, thanks for your interest in this project. I don't see any changes in the code! :) I see a new comment in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stop Android OpenSL capture before clearing its queued buffers instead of waiting indefinitely for the input queue to drain. Some USB conference devices can leave a capture buffer queued after delivery stalls; the previous unbounded drain then prevented recorder stop/deinitialization from returning.
Playback keeps its existing drain behavior. The change adds a source-level regression test that verifies capture does not drain, capture stops before its queue is cleared, and playback still drains. It is also documented under
## Unreleased.Closes #51.
Type of Change
Verification
flutter test test/opensl_capture_shutdown_test.dartflutter testflutter analyze lib test