Skip to content

Display implementation ignores formatting paramters #43

Description

@wainwrightmark

Hi. I'm not sure if this is intentional or not but the Display implementation ignores all formatting parameters

println!("ab{:>2}", "c"); //prints "ab c"
println!("ab{:>2}", Ustr::from_str("c").unwrap()); //prints "abc"

I believe this could be resolved by changing the current implementation to something like

impl fmt::Display for Ustr {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
       self.as_str().fmt(f)
    }
}

Obviously this would be a breaking change but possibly not a serious one as using formatting parameters currently does nothing, so it seems unlikely that anybody would be relying on the current behaviour.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions