Skip to content

refactor(multiple): stabilize focus state when active item is deleted#33199

Merged
tjshiu merged 1 commit into
angular:mainfrom
tjshiu:multi
May 6, 2026
Merged

refactor(multiple): stabilize focus state when active item is deleted#33199
tjshiu merged 1 commit into
angular:mainfrom
tjshiu:multi

Conversation

@tjshiu
Copy link
Copy Markdown
Contributor

@tjshiu tjshiu commented May 5, 2026

  • Calls setDefaultState instead of dropping focus when active item is removed.
  • Adds focus stability unit tests for listbox and tree.

@tjshiu
refactor(multiple): stabilize focus state when active item is deleted
aa58f92 
- Calls setDefaultState instead of dropping focus when active item is removed.
- Clears stale reference to prevent memory leaks.
- Adds focus stability unit tests for listbox and tree.
@pullapprove pullapprove Bot requested review from andrewseguin and crisbeto May 5, 2026 04:46
@tjshiu tjshiu requested review from adolgachev and ok7sai May 5, 2026 04:47
@tjshiu tjshiu added target: major This PR is targeted for the next major release dev-app preview When applied, previews of the dev-app are deployed to Firebase area: aria/listbox area: aria/combobox area: aria/tree labels May 5, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Deployed dev-app for aa58f92 to: https://ng-dev-previews-comp--pr-angular-components-33199-dev-yvaasibm.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@tjshiu tjshiu added target: minor This PR is targeted for the next minor release target: major This PR is targeted for the next major release and removed target: major This PR is targeted for the next major release area: aria/combobox target: minor This PR is targeted for the next minor release labels May 5, 2026
@tjshiu tjshiu added action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate and removed target: major This PR is targeted for the next major release labels May 5, 2026
@tjshiu tjshiu merged commit cd62949 into angular:main May 6, 2026
47 of 49 checks passed
@tjshiu
Copy link
Copy Markdown
Contributor Author

tjshiu commented May 6, 2026

This PR was merged into the repository. The changes were merged into the following branches:

tjshiu added a commit that referenced this pull request May 6, 2026
@tjshiu
refactor(multiple): stabilize focus state when active item is deleted (…
0aee554 
…#33199)

- Calls setDefaultState instead of dropping focus when active item is removed.
- Clears stale reference to prevent memory leaks.
- Adds focus stability unit tests for listbox and tree.

(cherry picked from commit cd62949)
@tjshiu tjshiu deleted the multi branch May 12, 2026 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adolgachev adolgachev adolgachev approved these changes

@ok7sai ok7sai ok7sai approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@crisbeto crisbeto Awaiting requested review from crisbeto

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: aria/listbox area: aria/tree dev-app preview When applied, previews of the dev-app are deployed to Firebase target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tjshiu @adolgachev @ok7sai