feat: add global and session video audio mute controls - #1594
Open
AndyWangLYN wants to merge 1 commit into
Open
AndyWangLYN wants to merge 1 commit into
AndyWangLYN wants to merge 1 commit into
Conversation
|
I second this Feature Request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Following this feature request: #1549
This PR adds two mute capabilities for video playback while preserving existing per-file audio preferences:
Global mute (persistent):
New audio setting: Mute all video audio.
Applies to all videos until the user turns it off.
Session mute (temporary):
New player toggle: Mute for this session (in playback speed overlay).
Applies only for the current player session.
Keeps per-file audio selection behavior intact.
Why
Users who watch familiar videos while listening to external music can now mute all video audio quickly without manually disabling tracks for each file. As in feature request: #1549
Implementation Notes
Added muteAllVideosAudio to PlayerPreferences.
Added new settings UI + event handling in Audio preferences.
Added player session commands for get/set session mute.
Player service now applies effective mute policy: globalMute || sessionMute.
Per-file track selections remain intact (no removal of existing per-item audio track behavior).