fix(player): fix returning playback position to external apps (Lampa, etc.) - #1846
Open
arabianq wants to merge 2 commits into
Open
fix(player): fix returning playback position to external apps (Lampa, etc.)#1846arabianq wants to merge 2 commits into
arabianq wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes playback position sync when NextPlayer is launched as an external player from third-party apps like Lampa. Previously, when closing the video, the playback progress wasn't returned and the video started from the beginning next time.
What changed
Always return playback result in
finish()Due to
singleTasklaunch mode,callingActivityis oftennullwhen launched from external apps. Previously,setResult()was wrapped inif (playerApi.shouldReturnResult)which relied oncallingActivity != null, causing the player to finish silently without returning timecodes. NowsetResult()is called unconditionally on finish.Improve Intent extra compatibility in
PlayerApiextra_position,position_extra,extra_duration,start) to the companion object.positiongetter that caused miscalculations for standard millisecond timestamps.Int(position) andLong(extra_position) ingetResult()to avoidClassCastExceptiondepending on how the calling app parses extras.onStop()Saved
lastKnownPositionandlastKnownDurationto ensure correct values are returned even if the media controller is released beforefinish()is called.Testing