Skip to content

Fix spec prefix capture on compressor-less Flash layers #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gilbert-barajas wants to merge 1 commit into from
Closed

Fix spec prefix capture on compressor-less Flash layers #648

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ds4.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19550,6 +19550,9 @@ static bool metal_graph_capture_prefix_attn_state(
uint32_t il,
uint32_t slot) {
if (!g->spec_capture_prefixes) return true;
/* Leading layers without an attention compressor (ratio 0) carry no
* frontier; mirror spec_frontier_snapshot/commit which skip them. */
if (ds4_layer_compress_ratio(il) == 0) return true;
if (slot >= DS4_SPEC_PREFIX_SLOTS ||
!g->spec_prefix1_attn_state_kv[il] ||
!g->spec_prefix1_attn_state_score[il]) {
Expand All @@ -19569,6 +19572,9 @@ static bool metal_graph_capture_prefix_index_state(
uint32_t il,
uint32_t slot) {
if (!g->spec_capture_prefixes) return true;
/* Index-compressor frontiers exist only on ratio-4 layers;
* mirror spec_frontier_snapshot/commit which skip the rest. */
if (ds4_layer_compress_ratio(il) != 4) return true;
if (slot >= DS4_SPEC_PREFIX_SLOTS ||
!g->spec_prefix1_index_state_kv[il] ||
!g->spec_prefix1_index_state_score[il]) {
Expand Down