Update TableDeleteException to use TableId type#6323
Open
ddanielr wants to merge 1 commit intoapache:mainfrom
Open
Update TableDeleteException to use TableId type#6323ddanielr wants to merge 1 commit intoapache:mainfrom
ddanielr wants to merge 1 commit intoapache:mainfrom
Conversation
The TableDeleteException was only used in places where a tableId was being passed into the Exception. Updates the Exception constructor to accept a TableId object. NOTE: this changes the public API and will require a deprecation in 2.1.x or a 3.x deprecation release.
keith-turner
approved these changes
Apr 17, 2026
Contributor
keith-turner
left a comment
keith-turner
left a comment
There was a problem hiding this comment.
this changes the public API and will require a deprecation in 2.1.x or a 3.x deprecation release.
Could leave the String constructors in 4.0 and deprecate them in 4.0 . Then could do it all in single commit. Its probably ok to drop them in 4.0 w/o deprecation, these are probably not used outside of accumulo code. If dropping w/o deprecation could always add them back in bug fix release like 4.0.1 as deprecated if needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TableDeleteException was only used in places where a tableId was being passed into the Exception.
Updates the Exception constructor to accept a TableId object.
NOTE: this changes the public API and will require a deprecation in 2.1.x or a 3.x deprecation release.
I could also pull this change back to the 2.1 branch and just add a new constructor method and change the string constructor to use a
TableId.of()call.