Skip to content

CLVM enhancements and fixes #12617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Pearl1594 wants to merge 54 commits into
base: main
Choose a base branch
from

fix merge conflict

9e31784
Select commit
Loading
Failed to load commit list.
Draft

CLVM enhancements and fixes #12617

fix merge conflict
9e31784
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Apr 27, 2026 in 5m 46s

Quality Gate failed

Failed conditions
1 Security Hotspot
33.8% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 56 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtPrepareForMigrationCommandWrapper.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 83 to 64, Complexity from 20 to 14, Nesting Level from 5 to 2, Number of Variables from 22 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ0sIVNClpSFCu4-z-Dh&open=AZ0sIVNClpSFCu4-z-Dh&pullRequest=12617

Check warning on line 1169 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace these 3 tests with a single Parameterized one. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ1EcZMYlli-YfopRUBT&open=AZ1EcZMYlli-YfopRUBT&pullRequest=12617

Check warning on line 2547 in server/src/test/java/com/cloud/storage/VolumeApiServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this and every subsequent useless "eq(...)" invocation; pass the values directly. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ0sIVjxlpSFCu4-z-Dy&open=AZ0sIVjxlpSFCu4-z-Dy&pullRequest=12617

Check warning on line 365 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused method parameter "host". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZz35YeN4256DVCsFLrX&open=AZz35YeN4256DVCsFLrX&pullRequest=12617

Check warning on line 2141 in engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 79 to 64, Complexity from 21 to 14, Nesting Level from 5 to 2, Number of Variables from 25 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ0sIVBclpSFCu4-z-Dg&open=AZ0sIVBclpSFCu4-z-Dg&pullRequest=12617

Check warning on line 109 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtClvmLockTransferCommandWrapper.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "Script"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ1pFLiFHBDapnzk6OhE&open=AZ1pFLiFHBDapnzk6OhE&pullRequest=12617

Check warning on line 492 in engine/storage/src/test/java/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelectorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Update this method so that its implementation is not identical to "testSelectObject_CLVMVolumeWithInvalidLockHostId" on line 476. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ1pFLWKHBDapnzk6Og6&open=AZ1pFLWKHBDapnzk6Og6&pullRequest=12617

Check warning on line 504 in engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 119 to 64, Complexity from 23 to 14, Nesting Level from 3 to 2, Number of Variables from 42 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ0sIVBclpSFCu4-z-De&open=AZ0sIVBclpSFCu4-z-De&pullRequest=12617

Check failure on line 351 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ0mNDXNmxdebns9DnLw&open=AZ0mNDXNmxdebns9DnLw&pullRequest=12617

Check failure on line 1086 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ1EcZMYlli-YfopRUBG&open=AZ1EcZMYlli-YfopRUBG&pullRequest=12617

Check warning on line 945 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "Script"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZxEJ4RLTdhpX5MPbvmD&open=AZxEJ4RLTdhpX5MPbvmD&pullRequest=12617

Check warning on line 1332 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace charset name argument with StandardCharsets.UTF_8 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZxEJ4MqTdhpX5MPbvl4&open=AZxEJ4MqTdhpX5MPbvl4&pullRequest=12617

Check warning on line 958 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this hard-coded path-delimiter. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZxEJ4RLTdhpX5MPbvmE&open=AZxEJ4RLTdhpX5MPbvmE&pullRequest=12617

Check failure on line 947 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "--unbuffered" 3 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZz35YeN4256DVCsFLrT&open=AZz35YeN4256DVCsFLrT&pullRequest=12617

Check warning on line 118 in server/src/test/java/com/cloud/storage/ClvmLockManagerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this and every subsequent useless "eq(...)" invocation; pass the values directly. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZycJTYW331ZRqy8rtiy&open=AZycJTYW331ZRqy8rtiy&pullRequest=12617

Check warning on line 7245 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace these 8 tests with a single Parameterized one. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ1FdYz3oC2Lq8aFxznP&open=AZ1FdYz3oC2Lq8aFxznP&pullRequest=12617

Check failure on line 133 in server/src/main/java/com/cloud/storage/ClvmLockManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 43 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ1pFL0JHBDapnzk6OhN&open=AZ1pFL0JHBDapnzk6OhN&pullRequest=12617

Check warning on line 74 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtPostMigrationCommandWrapperTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'org.libvirt.LibvirtException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ1pcbw51MRvjmKtxodK&open=AZ1pcbw51MRvjmKtxodK&pullRequest=12617

Check failure on line 1003 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ1EcZMYlli-YfopRUBC&open=AZ1EcZMYlli-YfopRUBC&pullRequest=12617

Check failure on line 1289 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ1EcZMYlli-YfopRUBP&open=AZ1EcZMYlli-YfopRUBP&pullRequest=12617

Check warning on line 3472 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ0xehk8DDwRlMHM1FEx&open=AZ0xehk8DDwRlMHM1FEx&pullRequest=12617

Check warning on line 3475 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ0xehk8DDwRlMHM1FEy&open=AZ0xehk8DDwRlMHM1FEy&pullRequest=12617

Check warning on line 770 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZxEJ4RLTdhpX5MPbvl8&open=AZxEJ4RLTdhpX5MPbvl8&pullRequest=12617

Check warning on line 76 in engine/storage/src/test/java/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelectorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_volDetailsDao" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ0xehRNDDwRlMHM1FEu&open=AZ0xehRNDDwRlMHM1FEu&pullRequest=12617

Check warning on line 280 in engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZycJS_0331ZRqy8rtiW&open=AZycJS_0331ZRqy8rtiW&pullRequest=12617
View more details on SonarQubeCloud