fix: Emit LIKE the way the Substrait extension defines it

[namanjain24-sudo]

Which issue does this PR close?

• Closes Substrait producer emits LIKE with three arguments and an undefined ilike function #25368.

Rationale for this change

functions_string.yaml defines one function for this, with two arguments and an option:

    name: like
    impls:
      - args:
          - value: "varchar<L1>"
            name: "input"
          - value: "varchar<L2>"
            name: "match"
        options:
          case_sensitivity:
            values: [ CASE_SENSITIVE, CASE_INSENSITIVE, CASE_INSENSITIVE_ASCII ]
        return: "boolean"

The producer emitted three arguments, registered ilike for the case insensitive form, and never set the option. Neither ilike nor an escape argument appears in any extension file, in the pinned crate or upstream.

What changes are included in this PR?

• make_substrait_like_expr registers like, emits the two arguments the definition takes, and sets case_sensitivity to CASE_INSENSITIVE for ILIKE. A plain LIKE sets no option, which leaves the default.
• LIKE ... ESCAPE is now not_impl_err. There is no escape in the definition, so the third argument only produced a call a consumer cannot bind.
• The consumer reads case_sensitivity, taking the first value it supports and refusing the ones it does not, as Substrait requires. It still accepts the ilike name and the three argument form, so plans written by an older DataFusion still load.

What is the testing strategy for this PR?

• New producer tests: LIKE emits like with two arguments and no option, ILIKE emits the case_sensitivity option, and an escape character is rejected.
• roundtrip_like and roundtrip_ilike still pass, which is what covers the consumer: with the option reading removed, roundtrip_ilike fails because ILIKE comes back as LIKE. Removing the producer half likewise fails the new producer test.
• cargo test -p datafusion-substrait passes and ./ci/scripts/rust_clippy.sh is clean.

Measured against substrait-java 0.103.0 and Spark 3.5.4, over t(s) holding abc and ABC, with the #11545 URN patched and output_type filled (#25049):

plan	before	after
s LIKE 'a%'	AnalysisException: WRONG_NUM_ARGS ... requires 2 parameters but the actual number is 3	runs, returns abc
s ILIKE 'a%'	IllegalArgumentException: Unexpected scalar function with key ilike:str_str	runs, returns abc

The second row is a trade-off worth stating. ILIKE used to fail loudly there, and now it is accepted but answered case sensitively, because substrait-spark does not read the option: case_sensitivity appears nowhere in its sources. Substrait says a consumer that does not recognise an option must reject the call, so that looks like a gap on that side, and I am happy to report it there. If you would rather not emit something a known consumer mishandles, the alternative is to reject ILIKE as well until a consumer honours the option, and I will change it.

Are there any user-facing changes?

LIKE and ILIKE are emitted in the form the extension defines, so consumers that bind arguments by the declaration can now read them. LIKE ... ESCAPE is rejected instead of being emitted in a shape no consumer can bind; DataFusion round trips it today only because its own consumer reads the same private convention.

This touches make_substrait_like_expr, which #25367 folds into from_like, so whichever lands second needs a small rebase.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 90.78014% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.72%. Comparing base (c3ef346) to head (231c2e4).
⚠️ Report is 32 commits behind head on main.

Files with missing lines	Patch %	Lines
.../src/logical_plan/consumer/expr/scalar_function.rs	89.23%	4 Missing and 3 partials ⚠️
.../src/logical_plan/producer/expr/scalar_function.rs	92.10%	2 Missing and 4 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #25442      +/-   ##
==========================================
+ Coverage   82.66%   82.72%   +0.06%     
==========================================
  Files        1147     1147              
  Lines      446357   448218    +1861     
  Branches   446357   448218    +1861     
==========================================
+ Hits       368971   370795    +1824     
+ Misses      54997    54906      -91     
- Partials    22389    22517     +128     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[namanjain24-sudo]

Bumping this — still open for review whenever someone has bandwidth.

[kosiew]

@namanjain24-sudo,

Thanks for working on this. The Substrait LIKE/ILIKE encoding now matches the extension contract. I left two non-blocking suggestions for additional consumer coverage and a small implementation simplification.

[kosiew]

Could we add table-driven tests for preference ordering and rejection cases, including CASE_INSENSITIVE_ASCII, mixed-case values, and empty preference lists? The code handles these cases, but the current roundtrip tests only cover the single preference emitted by DataFusion, so this could also be a follow-up.

[namanjain24-sudo]

Added case_insensitive_option_cases: covers preference ordering (including CASE_INSENSITIVE_ASCII being skipped since it's unsupported), mixed-case option/preference names, an empty preference list, and full rejection.

[kosiew]

One optional simplification would be to keep this serialization in from_like, or pass &Like to the helper instead of unpacking it into eight parameters. Since the helper has one caller, that would avoid the too_many_arguments suppression without changing behavior.

[namanjain24-sudo]

Done — inlined it back into from_like (single caller), so the too_many_arguments suppression is gone.