fix: Only apply SingleDistinctToGroupBy rewrite when it pays (closes #25932)

[mohitgurav20]

Which issue does this PR close?

Closes #25932

Rationale for this change

The SingleDistinctToGroupBy rule rewrites queries like SELECT g, sum(DISTINCT x) FROM t GROUP BY g into a two-step aggregation. While this rewrite can sometimes be faster, it can also consume over 2x more memory because the first step groups by both g and x.

DataFusion now has highly optimized GroupsAccumulator implementations for aggregates like sum, min, and max. If an aggregate natively supports GroupsAccumulator, the two-step rewrite is unnecessary and highly memory-inefficient.

Previously, the optimizer rule only checked if the rewrite was "worth it" if there was a count(*) in the query. If count(*) was absent, it blindly performed the memory-intensive rewrite.

What changes are included in this PR?

• Renamed rewrite_pays_for_count to rewrite_pays.
• Modified is_single_distinct_agg to apply the rewrite_pays check unconditionally for all queries, rather than gating it behind the presence of a count(*) rollup.
• Updated optimizer snapshot tests using cargo insta accept. As expected, many single distinct aggregation tests now produce simpler, single-step aggregation plans since the rewrite correctly bails out when the underlying aggregate supports GroupsAccumulator.

Are these changes tested?

Yes, the existing optimizer test suite validates these changes (with snapshots updated to reflect the new, more efficient plans for natively supported distinct aggregates).

[mkleen]

@mohitgurav20 Thanks for working on this.
Can you make sure all sql-logic tests pass, or correct them if invalid.
You can run them locally with:

cargo test --profile=ci --test sqllogictests

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.80%. Comparing base (334f293) to head (0923424).

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #26000   +/-   ##
=======================================
  Coverage   82.79%   82.80%           
=======================================
  Files        1149     1149           
  Lines      451645   451658   +13     
  Branches   451645   451658   +13     
=======================================
+ Hits       373940   373976   +36     
+ Misses      54929    54902   -27     
- Partials    22776    22780    +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mohitgurav20]

@mkleen sir i have completed the work and addressed ur suggestion pls feel free to review and would like to work if any changes needed.