fix: reset aggregate dynamic filters between recursive iterations - #26056
Draft
mikamikasuki wants to merge 2 commits into
Draft
mikamikasuki wants to merge 2 commits into
mikamikasuki wants to merge 2 commits into
Conversation
github-actions
Bot
added
physical-expr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #26054
Rationale for this change
In a recursive CTE, an uncorrelated MIN/MAX over a Parquet table returns the correct value on the first iteration but NULL or an incorrect value on later iterations because the aggregate reuses the dynamic filter tightened during the first scan.
What changes are included in this PR?
Reset AggregateExec's dynamic filter expression and shared accumulator bounds when the plan is reused, allowing each recursive iteration to scan with fresh bounds.
What is the testing strategy for this PR?
Added a cte.slt regression for the reported recursive MAX query. Validation passed:
cargo test -p datafusion-sqllogictest --test sqllogictests -- cte.slt;cargo test -p datafusion-physical-plan --lib(2,441 passed);cargo test -p datafusion-physical-expr --lib(1,686 passed, 2 ignored);cargo fmt --all -- --check; and targeted Clippy with-A clippy::ignore_without_reason -D warnings. The unsuppressed Rust 1.99 Clippy run reports the existingignore_without_reasonlint indatafusion/physical-expr/src/planner.rs.Are there any user-facing changes?
Recursive CTE iterations now return the correct aggregate result consistently while retaining dynamic-filter pruning.