Repository navigation
Conversation
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26067 +/- ##
==========================================
- Coverage 82.69% 82.69% -0.01%
==========================================
Files 1147 1147
Lines 447348 447446 +98
Branches 447348 447446 +98
==========================================
+ Hits 369936 370002 +66
- Misses 54999 55017 +18
- Partials 22413 22427 +14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #24937. This fixes the RANGE-window case; general MIN/MAX scalar comparisons remain separate.
Rationale for this change
A RANGE window ordered by a list containing lists or structs can plan successfully and then fail with
Uncomparable values. For example:CURRENT ROW boundaries only need to find equal ordering keys in the sorted input.
What changes are included in this PR?
Use Arrow's comparator to find nested CURRENT ROW peer boundaries. Reuse the comparator while the ordering arrays are unchanged and release it when buffered rows are pruned.
SQL type admission, scalar-key handling, and finite-offset calculations are unchanged.
What is the testing strategy for this PR?
Update the two existing SQL regressions from expected errors to successful counts. Physical-operator tests cover nested lists/structs, nulls, tied ordering keys across batches, frame boundaries, and completed-peer emission before EOF in sorted mode. A small state test covers comparator reuse and pruning.
Local validation on this patch:
cargo 0.100.0, pinned by the existingdev/depchecktool. This blocks the circular-dependency check and that tool's metadata inspection by cargo-machete; cargo-machete otherwise reported no unused dependencies. This patch changes no dependency manifests or lockfiles.Are there any user-facing changes?
Already-admitted SQL RANGE windows over nested list keys return results instead of an internal comparison error. The same boundary fix applies to windows constructed through the physical API. No new public API or SQL-admitted types are introduced.