Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
On a zero-row
List<Utf8>(or other non-primitive element type),array_min/array_maxfail withEmpty iterator passed to ScalarValue::iter_to_array.ProjectionExecandTopKevaluate expressions on empty batches, so the query fails instead of returning no rows.What changes are included in this PR?
array_min_max_helperreturnsnew_empty_array(&array.value_type())for an empty input before theScalarValuefallback. The primitive fast path is unchanged.min_max.rs: zero-rowList/LargeList<Utf8>, zero-rowList<Int64>, mixed rows, andinvoke_with_argswithnumber_rows: 0.Are these changes tested?
Yes. Without the fix, the zero-row
Utf8tests fail with the error above.Are there any user-facing changes?
No.