Repository navigation
chore: Add "Willingness to contribute" dropdown to issue templates - #26120
Conversation
asolimando
left a comment
There was a problem hiding this comment.
LGTM, the provided options and the wording used makes sense. I think it will be beneficial to move away from the take mechanism
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #26120 +/- ##
==========================================
+ Coverage 82.73% 82.74% +0.01%
==========================================
Files 1147 1147
Lines 449389 449756 +367
Branches 449389 449756 +367
==========================================
+ Hits 371788 372157 +369
+ Misses 54943 54925 -18
- Partials 22658 22674 +16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2010YOUY01
left a comment
There was a problem hiding this comment.
Thank you, I agree this would be helpful.
To other reviewers, you can preview by try opening an issue in comet: https://github.com/apache/datafusion-comet/issues
I also suggest we can mention the contributions should follow AI policy
| The Apache DataFusion community encourages bug fix contributions. Would you or another member of your organization be willing to contribute a fix for this bug to the Apache DataFusion codebase? | ||
| options: | ||
| - I can contribute a fix for this bug independently | ||
| - I would be willing to contribute a fix for this bug with guidance from the DataFusion community |
There was a problem hiding this comment.
I don't quite get this point, does that mean "I'm willing to contribute, but there are something I'm uncertain (described in issue), would open a PR after someone answer it"
There was a problem hiding this comment.
Maybe we could use the phrase "plan" instead of "am willing"?
Perhaps something like:
I plan contribute a fix for this bug independently
I would like contribute a fix for this bug, but request guidance from the DataFusion community
I cannot contribute a fix for this bug at this time
Should we also plan to remove the |
|
See related ticket |
Which issue does this PR close?
Rationale for this change
Ports apache/datafusion-comet#6688, which took the idea from the iceberg-rust issue templates. Reporters say up front whether they can contribute the fix or feature, so reviewers don't have to ask in a follow-up comment.
What changes are included in this PR?
Adds an optional "Willingness to contribute" dropdown with three options to
bug_report.ymlandfeature_request.yml. The wording is specific to bug fixes in the bug template and to features in the feature template.What is the testing strategy for this PR?
Issue templates have no automated tests. Both files parse as YAML and the dropdown has the same shape as in the iceberg-rust and Comet templates.
Are there any user-facing changes?
New issues filed from the bug report and feature request forms get one extra optional dropdown. There are no API changes.