Skip to content

fix: check for nix flake support before trying to load flake - #26188

Draft
VVKot wants to merge 1 commit into
apache:mainfrom
VVKot:vkot/envrc-detect-flake-support
Draft

VVKot wants to merge 1 commit into
apache:mainfrom
VVKot:vkot/envrc-detect-flake-support

Conversation

@VVKot

@VVKot VVKot commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

None.

Rationale for this change

#26122 (comment) - users might be running nix that doesn't support flakes.

What changes are included in this PR?

Test for flake support in addition to testing for nix being present.

What is the testing strategy for this PR?

Confirmed that flake is still being loaded when flakes are supported, and not loaded otherwise.

Are there any user-facing changes?

No.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.79%. Comparing base (334f293) to head (e3ed0fc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #26188      +/-   ##
==========================================
- Coverage   82.79%   82.79%   -0.01%     
==========================================
  Files        1149     1149              
  Lines      451645   451645              
  Branches   451645   451645              
==========================================
- Hits       373940   373932       -8     
- Misses      54929    54933       +4     
- Partials    22776    22780       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants