[FLINK-40108] Adding snapshot capability with split enumerator#209
Open
eskabetxe wants to merge 1 commit into
Open
[FLINK-40108] Adding snapshot capability with split enumerator#209eskabetxe wants to merge 1 commit into
eskabetxe wants to merge 1 commit into
Conversation
Member
Author
|
@RocMarshal @snuyanzin can you check please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new connection management layer for the Flink JDBC connector, adding support for pluggable connection providers and improved connection configuration. The changes include new classes for connection options, a builder for those options, a minimal
DataSourceimplementation for integration with connection pools, and interfaces for connection and statement handling. Additionally, HikariCP is added as a dependency (with SLF4J excluded), and a new async enumerator is provided for snapshot splitting.Connection Management and Configuration:
ConnectionOptionsandConnectionOptionsBuilderclasses to encapsulate and build JDBC connection configuration, including timeouts and properties. [1] [2]ConnectionDataSource, a minimalDataSourceimplementation that delegates driver resolution, enabling proper classloader handling with connection pools like HikariCP.ConnectionExceptionfor consistent error handling around connection issues.ConnectionProviderinterface, extending the base JDBC connection provider with methods for table/column metadata discovery and query building for snapshot splitters.Statement and Result Handling:
ResultSetMapperandStatementPreparerfunctional interfaces for mapping JDBC results and preparing statements, respectively. [1] [2]Async Snapshot Splitting:
AsyncSnapshotSplitterEnumerator, a background-threaded enumerator for computing and emitting snapshot splits asynchronously, improving scalability and responsiveness during snapshotting.Dependency Management:
pom.xml, with SLF4J excluded to avoid conflicts.