fix(go): add bound checking for refResolver and metaStringResolver reads#3615
Merged
chaokunyang merged 3 commits intoapache:mainfrom Apr 24, 2026
Merged
fix(go): add bound checking for refResolver and metaStringResolver reads#3615chaokunyang merged 3 commits intoapache:mainfrom
chaokunyang merged 3 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
This PR addresses two critical security vulnerabilities in the Fory Go runtime.
Both issues stemmed from trusting integer values (references/indices) read directly from the wire. A maliciously crafted payload could provide an out-of-bounds index (either too large or negative), triggering a runtime panic. In a server environment, this would allow an attacker to perform a Denial of Service (DoS) attack by crashing the Go process with a single malicious packet.
What does this PR do?
RefResolver: added an upper-bound check inGetReadObjectto ensurerefIddoes not exceed the size of thereadObjectsslice.MetaStringResolver: added a lower-bound check inReadMetaStringBytesto prevent negative index panics (e.g., when a header value of 1 is provided).Added unit tests in
ref_resolver_test.goandmeta_string_resolver_test.gothat specifically reproduce the OOB and negative-index panics.len-1) still function correctly.Related issues
Closes #3614
AI Contribution Checklist
yes/noyes, I included a completed AI Contribution Checklist in this PR description and the requiredAI Usage Disclosure.yes, my PR description includes the requiredai_reviewsummary and screenshot evidence of the final clean AI review results from both fresh reviewers on the current PR diff or current HEAD after the latest code changes.Does this PR introduce any user-facing change?
Benchmark
N/A