fix(dart): guard ref and meta-string index reads#3629
Open
miantalha45 wants to merge 6 commits intoapache:mainfrom
Open
fix(dart): guard ref and meta-string index reads#3629miantalha45 wants to merge 6 commits intoapache:mainfrom
miantalha45 wants to merge 6 commits intoapache:mainfrom
Conversation
Contributor
Author
|
@chaokunyang Have a look on this PR when you have time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR fixes two out-of-bounds bugs in the Dart runtime that were caused by trusting integer values read directly from the wire.
A malformed payload can provide an invalid reference id or meta-string index, which currently leads to a
RangeErrorinstead of a controlled failure. In a server environment, this can be used as a denial-of-service vector by crashing the Dart process with a single crafted packet.What does this PR do?
Bounds checking in
RefReader:Bounds checking in
MetaStringReader:Security and regression tests:
Related issues
Closes #3627
AI Contribution Checklist
yes/noyes, I included a completed AI Contribution Checklist in this PR description and the requiredAI Usage Disclosure.yes, my PR description includes the requiredai_reviewsummary and screenshot evidence of the final clean AI review results from both fresh reviewers on the current PR diff or current HEAD after the latest code changes.Does this PR introduce any user-facing change?