test(client): pin 1.7.0 backend_metrics shape with deterministic structural assertions#342
Open
Muawiya-contact wants to merge 2 commits into
Open
Conversation
…ctural assertions
Contributor
Author
|
@imbajin, any feedback please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test(client): pin 1.7.0 backend_metrics shape with deterministic structural assertions
Closes #326
What does this PR do?
Replaces the loose
assertGreater(len(...), 1)check intest_metric.pywith deterministic structural assertions based on the actual/metrics/backendresponse captured from a real HugeGraph server.The problem
The old assertion only checked length — shape drift in the API response would pass silently without any test failure.
The fix
What was verified
/metrics/backendresponse from a real HugeGraph serverEXPECTED_BACKEND_SERVER_KEYSfrom that real responsebackend,nodes,cluster_id,serversfields exist with correct typesTest results
Both versions return identical shapes — one assertion covers both.
Files changed
Only one file touched:
hugegraph-python-client/src/tests/api/test_metric.py