fix(sdk): respect max_buffer_size when merging batches - #3933
Merged
Conversation
|
Thanks for the PR. It is labeled Slash commands (own line, regular comment) move it around the queue:
See CONTRIBUTING.md for details. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3933 +/- ##
============================================
- Coverage 84.95% 84.80% -0.16%
Complexity 1405 1405
============================================
Files 1225 1225
Lines 179727 179932 +205
Branches 146014 146219 +205
============================================
- Hits 152689 152590 -99
- Misses 23013 23282 +269
- Partials 4025 4060 +35
🚀 New features to boost your workflow:
|
numinnex
reviewed
Aug 25, 2026
numinnex
reviewed
Aug 25, 2026
spetz
previously approved these changes
Aug 31, 2026
hubcio
previously approved these changes
Aug 31, 2026
spetz
previously approved these changes
Aug 31, 2026
hubcio
previously approved these changes
Aug 31, 2026
spetz
force-pushed
the
fix/sdk-producer-max-buffer
branch
from
August 31, 2026 12:13
0bd1468 to
2fef029
Compare
spetz
approved these changes
Aug 31, 2026
mmodzelewski
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR address?
Closes #3932
Rationale
Respect the
max_buffer_sizesuch that the BackpressureMode can kick in.What changed?
Merge both inner IggyMessages and the OwnedSemaphorePermits (bytes_permit), freeing only when written, not after merge.
Local Execution
AI Usage
None